haveno-network/haveno-core
haveno-network/haveno-core
1
0
Fork 1
Code Issues 4 Pull requests Projects 5 Releases 1 Packages Wiki Activity Actions

fix startup when missing multisig wallets

Browse source
This commit is contained in:
woodser 2025-04-11 17:51:05 -04:00 committed by woodser
parent 5bff265cca
commit 454fc91298
5 changed files with 36 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
core/src/main/java/haveno/core/trade/Trade.java
View file

@ -753,11 +753,9 @@ public abstract class Trade extends XmrWalletBase implements Tradable, Model {
importMultisigHexIfScheduled();
});
// trade is initialized
isInitialized = true;
// done if deposit not requested or payout unlocked
if (!isDepositRequested() || isPayoutUnlocked()) {
isInitialized = true;
isFullyInitialized = true;
return;
}
@ -769,14 +767,17 @@ public abstract class Trade extends XmrWalletBase implements Tradable, Model {
if (payoutTx != null && payoutTx.getNumConfirmations() >= XmrWalletService.NUM_BLOCKS_UNLOCK) {
log.warn("Payout state for {} {} is {} but payout is unlocked, updating state", getClass().getSimpleName(), getId(), getPayoutState());
setPayoutStateUnlocked();
isInitialized = true;
isFullyInitialized = true;
return;
} else {
log.warn("Missing trade wallet for {} {}, state={}, marked completed={}", getClass().getSimpleName(), getShortId(), getState(), isCompleted());
return;
throw new RuntimeException("Missing trade wallet for " + getClass().getSimpleName() + " " + getShortId() + ", state=" + getState() + ", marked completed=" + isCompleted());
}
}
// trade is initialized
isInitialized = true;
// init syncing if deposit requested
if (isDepositRequested()) {
tryInitSyncing();

4
core/src/main/java/haveno/core/trade/TradeManager.java
View file

@ -470,6 +470,7 @@ public class TradeManager implements PersistedDataHost, DecryptedDirectMessageLi
if (!isShutDownStarted) {
log.warn("Error initializing {} {}: {}\n", trade.getClass().getSimpleName(), trade.getId(), e.getMessage(), e);
trade.setInitError(e);
trade.prependErrorMessage(e.getMessage());
}
}
});
@ -1041,7 +1042,7 @@ public class TradeManager implements PersistedDataHost, DecryptedDirectMessageLi
if (isShutDownStarted) return;
synchronized (tradableList.getList()) {
for (Trade trade : tradableList.getList()) {
if (!trade.isPayoutPublished()) {
if (!trade.isInitialized() || trade.isPayoutPublished()) continue;
Date maxTradePeriodDate = trade.getMaxTradePeriodDate();
Date halfTradePeriodDate = trade.getHalfTradePeriodDate();
if (maxTradePeriodDate != null && halfTradePeriodDate != null) {
@ -1057,7 +1058,6 @@ public class TradeManager implements PersistedDataHost, DecryptedDirectMessageLi
}
}
}
}
///////////////////////////////////////////////////////////////////////////////////////////

2
core/src/main/java/haveno/core/xmr/wallet/XmrWalletService.java
View file

@ -689,6 +689,7 @@ public class XmrWalletService extends XmrWalletBase {
}
private MoneroTxWallet createTradeTxFromSubaddress(BigInteger feeAmount, String feeAddress, BigInteger sendAmount, String sendAddress, Integer subaddressIndex) {
synchronized (walletLock) {
// create tx
MoneroTxConfig txConfig = new MoneroTxConfig()
@ -706,6 +707,7 @@ public class XmrWalletService extends XmrWalletBase {
freezeOutputs(keyImages);
return tradeTx;
}
}
public MoneroTx verifyReserveTx(String offerId, BigInteger penaltyFee, BigInteger tradeFee, BigInteger sendTradeAmount, BigInteger securityDeposit, String returnAddress, String txHash, String txHex, String txKey, List<String> keyImages) {
BigInteger sendAmount = sendTradeAmount.add(securityDeposit).add(tradeFee).subtract(penaltyFee);

1
desktop/src/main/java/haveno/desktop/main/MainViewModel.java
View file

@ -228,6 +228,7 @@ public class MainViewModel implements ViewModel, HavenoSetup.HavenoSetupListener
new Popup().warning("Error initializing trade" + " " + trade.getShortId() + "\n\n" +
trade.getInitError().getMessage())
.show();
return;
}
// check trade period

1
desktop/src/main/java/haveno/desktop/main/portfolio/pendingtrades/steps/TradeStepView.java
View file

@ -405,6 +405,7 @@ public abstract class TradeStepView extends AnchorPane {
}
private void updateTimeLeft() {
if (!trade.isInitialized()) return;
if (timeLeftTextField != null) {
// TODO (woodser): extra TradeStepView created but not deactivated on trade.setState(), so deactivate when model's trade is null